Create namespace with references for modules #4646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zherczeg
commented
Apr 8, 2021
|
|
||
| import * as o from "module-circular-01.mjs" | ||
|
|
||
| if (o.early != "Loaded") |
Member
Author
There was a problem hiding this comment.
Is it possible to not run a test in this directory? Not really a problem if not, just asking. Perhaps adding a bad extension, e.g. ._mjs
zherczeg
force-pushed
the
module_scope
branch
10 times, most recently
from
2058cd2 to
39dba1a
Compare
Member
Author
|
This patch is ready, please check. |
rerobika
approved these changes
Apr 12, 2021
Member
rerobika
left a comment
rerobika
left a comment
There was a problem hiding this comment.
LGTM after this minor issue.
| #if JERRY_MODULE_SYSTEM | ||
|
|
||
| extern inline ecma_property_value_t * JERRY_ATTR_ALWAYS_INLINE | ||
| ecma_get_property_value_from_named_reference (ecma_property_value_t *reference_p) /**< data property reference */ |
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.